Configure local Preact dependencies #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewiggins
force-pushed
the
local-dev-mode
branch
2 times, most recently
from
5ce576d to
b2f0af8
Compare
marvinhagemeister
approved these changes
Mar 7, 2024
andrewiggins
force-pushed
the
local-dev-mode
branch
from
e0347c1 to
afb50e7
Compare
On a fresh install of the repo, the tarballs for dependencies such as preact-local won't be present and so those dependencies won't have preact locally installed. Therefore typechecking will fail in those dependencies. Our CI is a fresh install of the repository and so the CI will always fail this typecheck. For the time being until a better workaround is found, I'm removing typechecking deps from the CI
andrewiggins
force-pushed
the
local-dev-mode
branch
from
a19e545 to
e64e06d
Compare
Helps reporters like tachometer-reporter-action
andrewiggins
force-pushed
the
local-dev-mode
branch
2 times, most recently
from
b9fa9a1 to
767af01
Compare
andrewiggins
force-pushed
the
local-dev-mode
branch
from
767af01 to
71ba7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic development workflow for when this repository is submoduled into another repository. Check the Readme changes for a description of what this change entails/enables.
Also, it now re-installed dependencies before each benchmark run to ensure they are up-to-date with their latest spec, as well as any changes tarballs are unpacked and installed.