Skip to content

Commit

Permalink
Remove checking tsc:deps from lint script
Browse files Browse the repository at this point in the history
On a fresh install of the repo, the tarballs for dependencies such as preact-local won't be present and so those dependencies won't have preact locally installed. Therefore typechecking will fail in those dependencies. Our CI is a fresh install of the repository and so the CI will always fail this typecheck.

For the time being until a better workaround is found, I'm removing typechecking deps from the CI
  • Loading branch information
andrewiggins committed Mar 6, 2024
1 parent f95fdec commit 43cad41
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"lint-staged": "lint-staged",
"prepare": "husky install",
"start": "node cli/bin/preact-bench.js start",
"tsc": "npm run tsc:apps && npm run tsc:cli && npm run tsc:deps",
"tsc": "npm run tsc:apps && npm run tsc:cli",
"tsc:apps": "tsc -p apps/jsconfig.json",
"tsc:cli": "tsc -p cli/jsconfig.json",
"tsc:deps": "tsc -p dependencies/jsconfig.json"
Expand Down

0 comments on commit 43cad41

Please sign in to comment.