Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-370] Fix all javadoc "no return" warnings #430

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

crazyzhou
Copy link
Contributor

Signed-off-by: Brian Zhou [email protected]

Change log description

  • Fix all javadoc "no return" warnings

Purpose of the change
Fixes #370

What the code does

  • Fix all javadoc no return warnings
  • Adjust the code coverage constraint.

How to verify it
./gradlew clean build passes
Should cherry-pick to all 0.9 branches.

@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #430 (4f34b1b) into master (5366698) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #430   +/-   ##
=========================================
  Coverage     83.93%   83.93%           
  Complexity      420      420           
=========================================
  Files            34       34           
  Lines          1905     1905           
  Branches        204      204           
=========================================
  Hits           1599     1599           
  Misses          164      164           
  Partials        142      142           
Impacted Files Coverage Δ Complexity Δ
...ravega/connectors/flink/AbstractReaderBuilder.java 86.48% <ø> (ø) 14.00 <0.00> (ø)
...nnectors/flink/AbstractStreamingReaderBuilder.java 96.87% <ø> (ø) 20.00 <0.00> (ø)
...nnectors/flink/AbstractStreamingWriterBuilder.java 94.73% <ø> (ø) 5.00 <0.00> (ø)
...ravega/connectors/flink/AbstractWriterBuilder.java 87.50% <ø> (ø) 9.00 <0.00> (ø)
...vega/connectors/flink/FlinkPravegaInputFormat.java 95.34% <ø> (ø) 17.00 <0.00> (ø)
...ega/connectors/flink/FlinkPravegaOutputFormat.java 86.25% <ø> (ø) 20.00 <0.00> (ø)
...o/pravega/connectors/flink/FlinkPravegaReader.java 76.88% <ø> (ø) 31.00 <0.00> (ø)
...ravega/connectors/flink/FlinkPravegaTableSink.java 82.35% <ø> (ø) 8.00 <0.00> (ø)
...ava/io/pravega/connectors/flink/PravegaConfig.java 77.41% <ø> (ø) 19.00 <0.00> (ø)
...ga/connectors/flink/table/descriptors/Pravega.java 84.82% <ø> (ø) 18.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5366698...4f34b1b. Read the comment docs.

Copy link
Contributor

@maddisondavid maddisondavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazyzhou crazyzhou merged commit e9d5a98 into pravega:master Jan 5, 2021
@crazyzhou crazyzhou deleted the issue-370-fix-build-warnings branch January 5, 2021 02:33
crazyzhou added a commit that referenced this pull request Jan 28, 2021
crazyzhou added a commit that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build warnings
2 participants