Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dog Breed Identification #1107

Merged
merged 8 commits into from
Oct 23, 2022
Merged

Conversation

Knighthawk-Leo
Copy link
Contributor

@Knighthawk-Leo Knighthawk-Leo commented Oct 15, 2022

Issue #1106

  • Hacktoberfest2022 Participant

Description
It's A Python -Django based Script build to find the breed of the dog the user uploaded
Files Changed

  • Upload the Django Script for the Web app
  • Includes Webapp , Templates and static files.
    Type of change

Checklist:

My code follows the guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly where ever it was hard to understand.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
Any dependent changes have been merged and published in downstream modules.
Screenshots
Screenshots are attached for reference.

@Knighthawk-Leo
Copy link
Contributor Author

@prathimacode-hub please review my PR

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make things clear of what are the files you had included in your PR? @Knighthawk-Leo

@Knighthawk-Leo
Copy link
Contributor Author

Knighthawk-Leo commented Oct 22, 2022

Can you make things clear of what are the files you had included in your PR? @Knighthawk-Leo

Yeah @prathimacode-hub updated the PR

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Appreciate work. 👍👏@Knighthawk-Leo

@prathimacode-hub prathimacode-hub added HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest Approved This PR is approved labels Oct 22, 2022
@prathimacode-hub
Copy link
Owner

Correct the README file. You have also included contributing guidelines in it and also refer to the README template provided as well for better understanding of the project. You can elaborate much briefer about the project. @Knighthawk-Leo

@Knighthawk-Leo
Copy link
Contributor Author

@prathimacode-hub Done

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you seen the README template? @Knighthawk-Leo

@Knighthawk-Leo
Copy link
Contributor Author

@prathimacode-hub Updated the Readme.md

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. ✔👌@Knighthawk-Leo

@prathimacode-hub prathimacode-hub merged commit c5b6c88 into prathimacode-hub:main Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This PR is approved HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants