Merge pull request #260 from smoogipoo/fix-error-on-self-friend

Fix connection errors on self-friends
ppy · Jan 16, 2025 · 2d51d49 · 2d51d49
2 parents 8987732 + 05b30c0
commit 2d51d49
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/osu.Server.Spectator/Hubs/Metadata/MetadataHub.cs b/osu.Server.Spectator/Hubs/Metadata/MetadataHub.cs
@@ -75,6 +75,11 @@ public override async Task OnConnectedAsync()
                 {
                     foreach (int friendId in await db.GetUserFriendsAsync(usage.Item.UserId))
                     {
+                        // Once upon a time users were able to add themselves as friends.
+                        // This errors during the state retrieval below, so let's not support it.
+                        if (friendId == usage.Item.UserId)
+                            continue;
+
                         await Groups.AddToGroupAsync(Context.ConnectionId, FRIEND_PRESENCE_WATCHERS_GROUP(friendId));
 
                         // Check if the friend is online, and if they are, broadcast to the connected user.