Add minimal sentry logging on mysql errors that were previously dropped

osu.Server.Spectator/Database/DatabaseAccess.cs

@@ -7,6 +7,7 @@
 using System.Linq;
 using System.Threading.Tasks;
 using Dapper;
+using Microsoft.Extensions.Logging;
 using Microsoft.IdentityModel.JsonWebTokens;
 using MySqlConnector;
 using osu.Game.Online.Metadata;
@@ -19,6 +20,12 @@ namespace osu.Server.Spectator.Database
     public class DatabaseAccess : IDatabaseAccess
     {
         private MySqlConnection? openConnection;
+        private readonly ILogger<DatabaseAccess> logger;
+
+        public DatabaseAccess(ILoggerFactory loggerFactory)
+        {
+            logger = loggerFactory.CreateLogger<DatabaseAccess>();
+        }
 
         public async Task<int?> GetUserIdFromTokenAsync(JsonWebToken jwtToken)
         {
@@ -180,12 +187,9 @@ public async Task AddLoginForUserAsync(int userId, string? userIp)
                     IP = userIp
                 });
             }
-            catch (MySqlException)
+            catch (MySqlException ex)
             {
-                // we really don't care about failures in this as it's throwaway logging.
-                //
-                // although arguably we should at least be logging failures somewhere because this kind of thing could stop working
-                // without anyone noticing. same goes for other try-catch methods in this class..
+                logger.LogWarning(ex, "Could not log login for user {UserId}", userId);
             }
         }
 

osu.Server.Spectator/Database/DatabaseFactory.cs

@@ -1,10 +1,19 @@
 // Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using Microsoft.Extensions.Logging;
+
 namespace osu.Server.Spectator.Database
 {
     public class DatabaseFactory : IDatabaseFactory
     {
-        public IDatabaseAccess GetInstance() => new DatabaseAccess();
+        private readonly ILoggerFactory loggerFactory;
+
+        public DatabaseFactory(ILoggerFactory loggerFactory)
+        {
+            this.loggerFactory = loggerFactory;
+        }
+
+        public IDatabaseAccess GetInstance() => new DatabaseAccess(loggerFactory);
     }
 }

osu.Server.Spectator/Startup.cs

@@ -69,7 +69,7 @@ public void ConfigureServices(IServiceCollection services)
                 logging.ClearProviders();
                 logging.AddConsole();
 #if !DEBUG
-                logging.AddSentry();
+                logging.AddSentry(options => options.MinimumEventLevel = LogLevel.Warning);
 #endif
 
                 // IdentityModelEventSource.ShowPII = true;