Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE] Use django-sri for sri hashes #158

Merged
merged 1 commit into from
Feb 2, 2025
Merged

[CHANGE] Use django-sri for sri hashes #158

merged 1 commit into from
Feb 2, 2025

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Feb 2, 2025

Description

Changed

  • Use django-sri for sri hashes
  • Minimum requirements
    • Alliance Auth >= 4.6.0

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (15d8eae) to head (971284a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sovtimer/templatetags/sovtimer.py 83.34% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   66.67%   68.79%   +2.12%     
==========================================
  Files          12       13       +1     
  Lines         312      346      +34     
  Branches       28       31       +3     
==========================================
+ Hits          208      238      +30     
- Misses         99      101       +2     
- Partials        5        7       +2     
Files with missing lines Coverage Δ
sovtimer/constants.py 100.00% <100.00%> (ø)
sovtimer/helper/static_files.py 100.00% <100.00%> (ø)
sovtimer/templatetags/sovtimer.py 85.19% <83.34%> (-14.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d8eae...971284a. Read the comment docs.

@ppfeufer ppfeufer merged commit 73f3c64 into master Feb 2, 2025
56 checks passed
@ppfeufer ppfeufer deleted the django-sri branch February 2, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant