Do not try to get xattrs for the root inode #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the path in the S3 request is empty, which is invalid.
|
Uh, I guess this changes the plan: kahing@e3748e3 |
|
I applied your patch to kahing/goofys and it worked very well. It would be nice if you submitted it as a PR there, too, or do you still recommend switching to ppenguin's fork? |
|
@kjetilho Better late than never.. kahing#672 (Although I guess the kahing version is again out of maintenance.) |
djmaze
added a commit
to djmaze/goofys-docker
that referenced
this pull request
Jan 18, 2022
That fixes a bug with xattrs (see ppenguin/goofys#2)
|
Hello @djmaze, I'd like to apply this patch via kahing#672. I would also like to get up to date on the latest from https://github.com/kahing/goofys. I noticed that this repo forks https://github.com/kahing/goofys & there are some unique commits in this repo. Is there a benefit to using the commits from this repo or should I focus solely on kashing/goofys? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the path in the S3 request is empty, which is invalid.
fixes kahing#522
Doing the PR here since the kahing version seems not maintained anymore and I am using your fork either way.