Updates for analytics processors #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thegoldenmule
commented
Jan 22, 2025
thegoldenmule
commented
- Updated the template
- Updated the rwa-analytics processor
- Updated some setup
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
froid1911
requested changes
Jan 22, 2025
| @@ -22,7 +22,12 @@ export const DefaultReactorOptions = { | |||
|
|
|||
| async function startLocalReactor(reactorOptions: ReactorOptions) { | |||
| const baseConfig = getConfig(); | |||
| const options = { ...DefaultReactorOptions, ...reactorOptions }; | |||
| console.log("baseConfig", baseConfig); | |||
| @@ -2,6 +2,6 @@ import { startServer } from "./server"; | |||
|
|
|||
| export * from "./server"; | |||
|
|
|||
| startServer({ dev: true }).catch((error: unknown) => { | |||
| startServer({ dev: true, dbPath: "postgresql://postgres:password@localhost:5555/analytics" }).catch((error: unknown) => { | |||
There was a problem hiding this comment.
do we want, that the local reactor requires a local postgres installation by default? I think thats going to break a lot of things.
There was a problem hiding this comment.
Yah, probably.
| * Delete the file and run the code generator again to have it reset | ||
| */ | ||
|
|
||
| export * as RwaAnalyticsProcessor from "./rwa-analytics"; |
There was a problem hiding this comment.
doe we want the rwa analytics processor as default package for all local reactor installations?
|
@thegoldenmule do we want to close this? |
|
Sorry @froid1911 just saw this. I will check it out tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.