Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor defineLoader #246

Merged
merged 203 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
203 commits
Select commit Hold shift + click to select a range
e799280
feat: initial work
posva Aug 3, 2023
0eb785e
feat: wip
posva Aug 3, 2023
87d8761
test: dts
posva Aug 3, 2023
717fcc4
feat: working nested loaders
posva Aug 4, 2023
1fc4431
test: launch.json
posva Aug 4, 2023
4856fa1
feat: working nested loaders with more robust tests and logs
posva Aug 4, 2023
2e4decc
test: refactor using target route in returned values
posva Aug 4, 2023
fbabe0e
chore: comment out logs
posva Aug 4, 2023
e5afa79
test: resolve lazy once
posva Aug 4, 2023
7ebf6b7
refactor: rename ssrKey to key and add server option
posva Aug 5, 2023
d4d2f46
feat(data-fetching): add server option
posva Aug 5, 2023
a6efe87
test: dts meta extensions
posva Aug 5, 2023
279c5bc
test: improvements
posva Aug 5, 2023
03ee1ce
chore:vscode settings
posva Aug 8, 2023
56b2a4d
feat: commit option
posva Aug 8, 2023
d2dda40
feat: return a promise of data only
posva Aug 8, 2023
aac66c1
fix: discard loads from canceled navigations
posva Aug 8, 2023
a089915
chore: playground updates
posva Aug 8, 2023
9187267
chore: avoid spread operator in runtime
posva Aug 8, 2023
e5ee28b
build: more recent ts
posva Aug 9, 2023
007ff6f
refactor: better multi app support and cleaning
posva Aug 9, 2023
e4fad8b
chore: cleanup
posva Aug 9, 2023
73a6cc5
fix: run nested loaders once when used across places
posva Aug 9, 2023
365e6e6
chore: testing in playground
posva Aug 9, 2023
2e38544
feat: handle thrown errors
posva Aug 9, 2023
8514508
refactor: create a plugin instead
posva Aug 9, 2023
2d15df0
refactor: use plugin
posva Aug 9, 2023
9d95e27
feat: run loaders with access to global inject and provide
posva Aug 9, 2023
b0aa0b3
feat: inject in nested loaders
posva Aug 9, 2023
5129e44
refactor: expose plugin and rework defineLoader types
posva Aug 9, 2023
a175fa7
feat(data-loaders): add abort signal to navigation
posva Aug 11, 2023
72f158b
chore: comments
posva Aug 11, 2023
afabb47
feat(data-loaders): abort the signal for old pending locations
posva Aug 11, 2023
7de505a
chore: comments
posva Aug 11, 2023
85d0494
feat(data-loaders): pass the signal to the loader
posva Aug 11, 2023
fd038ee
refactor: options for setup loading guard
posva Aug 11, 2023
7a7da74
feat(data-loaders): allow changing the navigation result
posva Aug 11, 2023
8ddee57
chore: playground updates
posva Aug 12, 2023
8d829a5
refactor: minor type fixes
posva Aug 13, 2023
0d61062
feat(data-loaders): initialData for ssr
posva Aug 13, 2023
baf35ed
chore: note [skip ci]
posva Aug 13, 2023
7351322
chore: docs
posva Aug 14, 2023
e60298c
chore: playground stuff
posva Aug 17, 2023
2287286
test: refactor into reusable test
posva Aug 17, 2023
75a55f2
new pages and stuff
posva Oct 22, 2023
535264c
refactor: required options
posva Oct 22, 2023
b9f44f7
wip vuefire loader
posva Oct 22, 2023
0251e0d
wip vue query loader
posva Oct 22, 2023
54ae51d
refactor: interop cjs (#210)
sxzz Oct 23, 2023
cda9228
chore; up deps
posva Oct 26, 2023
0b4b9e7
missing routerrview
posva Nov 27, 2023
9d0e5ae
chore: dup line
posva Nov 28, 2023
e90c5d3
refactor: rename `defineLoader` to `defineBasicLoader`
posva Nov 28, 2023
c69f953
chore: link in playground
posva Nov 28, 2023
9bb3da8
refactor: playground tests
posva Nov 28, 2023
bba1786
chore: remove old export
posva Nov 28, 2023
cea62d7
feat: deprecate `defineLoader`
posva Nov 28, 2023
1ca019e
chore: move brainstorming file to avoid errors
posva Nov 28, 2023
b3ce5ad
test: fix compat node 16
posva Nov 28, 2023
9273f66
ci: fix windows
posva Nov 29, 2023
54cc0b0
chore: up versions
posva Dec 19, 2023
468af33
chore: up vitest
posva Dec 19, 2023
5c957f4
refactor: remove broken webpack example
posva Dec 19, 2023
23f9bb8
chore: nuxt is also broken
posva Dec 19, 2023
a29845b
chore: adapt playground to tests
posva Dec 19, 2023
8705d86
refactor: use new symbol to detect old data loaders
posva Dec 19, 2023
c24e33d
chore: playground query
posva Dec 19, 2023
ad5f4c0
feat: add for old data fetching methods
posva Dec 19, 2023
0c0e2a6
test: add ssrKeyName
posva Dec 26, 2023
6462990
chore: notes
posva Dec 26, 2023
673f1a3
refactor: rework new basic data fetching
posva Dec 30, 2023
ce890c1
types: use RouterTyped in createRouter
posva Jan 2, 2024
27a5897
chore: remove unused esno
posva Jan 4, 2024
1544363
fix: use single alias for reused components on different paths
PindaPixel Dec 27, 2023
5a8113e
style: fix lint
posva Jan 4, 2024
9e24746
test: dedupe default sync imports
posva Jan 4, 2024
d1e24ef
chore: up deps
posva Jan 4, 2024
61df2df
chore: refactor playground
posva Jan 4, 2024
da713a3
refactor: use raw type instead of promise for generic in loaders
posva Jan 4, 2024
a4e275b
chore: comment
posva Jan 4, 2024
405a4ae
types: convenient vue router typed locations
posva Jan 5, 2024
cb8abfe
chore: ignore vitest temp file
posva Jan 5, 2024
04c92c5
docs: note about import
posva Jan 5, 2024
bf66263
test: ignore files for type checking
posva Jan 5, 2024
7d85ef8
chore: update tsconfig
posva Jan 5, 2024
9854411
chore: playground tests
posva Jan 5, 2024
bc0160e
refactor: use a TypesConfig to handle loader types
posva Jan 5, 2024
8f1b286
refactor: node import
posva Jan 5, 2024
1427b23
refactor: move types to types submodule
posva Jan 5, 2024
32db454
test: fix types
posva Jan 5, 2024
8d6f28a
ci: fix
posva Jan 6, 2024
6a56c84
refactor: remove ~ alias
posva Jan 6, 2024
322f220
perf: compute params once
posva Jan 6, 2024
0b71ad5
fix(types): remove null from non raw star param
posva Jan 6, 2024
887ffa2
refactor: import with types
posva Jan 6, 2024
01ce6fc
refactor: rename folder
posva Jan 6, 2024
a4b8702
chore: remove comments
posva Jan 6, 2024
eec785a
refactor: deprecate RouteMeta addition
posva Jan 6, 2024
c11cfab
refactor(types): use define loader type helper
posva Jan 6, 2024
26d83a5
chore: note
posva Jan 6, 2024
a8c813a
refactor: use types imports
posva Jan 6, 2024
3f01155
fix(types): correct types in navigation guards
posva Jan 6, 2024
2aaaf56
feat(loaders): thrown navigation results take precedence
posva Jan 6, 2024
bba2de4
style: trimStart
posva Jan 6, 2024
791d27d
chore: type import
posva Jan 6, 2024
6a6abc5
chore: add GH settings
posva Jan 8, 2024
c44d34b
refactor: imports
posva Jan 8, 2024
862412d
ci: upgrade node versions
posva Jan 9, 2024
4c00cf4
chore: cacheTime comment wrong (#293)
ChuHoMan Jan 11, 2024
f4453db
chore: use own ts
posva Jan 11, 2024
74ff2f2
types: avoid crashing ts server
posva Jan 11, 2024
ba429dd
test: refactor to factory
posva Jan 11, 2024
ac6dde3
test: refactor define loader tests
posva Jan 11, 2024
32e30ac
test: remove basic wrap
posva Jan 11, 2024
6a0ca43
chore: todos
posva Jan 11, 2024
edb41e1
types: extensible EntryMap
posva Jan 11, 2024
4511170
feat: wip pinia-colada
posva Jan 11, 2024
5cc1657
test: refactor to allow plugins
posva Jan 11, 2024
61aa0a6
feat: wip colada loader
posva Jan 11, 2024
fba3714
types: more flexible navigationguard tyes
posva Jan 12, 2024
a83071e
chore: comments
posva Jan 14, 2024
629bf23
build: update tsconfig
posva Jan 14, 2024
1d492eb
chore: comment
posva Jan 14, 2024
8748644
fix(types): restrict what can be imported from the package
posva Jan 14, 2024
3c4a4ce
chore: remove file
posva Jan 15, 2024
856c184
chore: add missing d.ts
posva Jan 16, 2024
092e8bc
chore: add vue-tsc
posva Jan 16, 2024
9502751
refactor: rename `pending` to `isLoading`
posva Jan 16, 2024
7070e56
chore: up deps
posva Jan 16, 2024
3c83992
docs: wip
posva Jan 18, 2024
02e20d6
style: format
posva Jan 18, 2024
49e9c60
chore: update example (#297)
antfu Jan 18, 2024
d5c5b7e
chore: up
posva Jan 18, 2024
7cf95fe
style: format
posva Jan 18, 2024
683b0a1
chore: override shikiji versions
posva Jan 19, 2024
2dc0446
fix(types): use `vue-router/auto-routes`
posva Jan 19, 2024
b9b866f
Merge pull request #298 from posva/docs
posva Jan 19, 2024
6194b6c
chore: update shikiji (#299)
antfu Jan 19, 2024
5d9ebf9
docs: update shiki
posva Feb 7, 2024
49dd43b
chore: up deps
posva Feb 7, 2024
bc1b3cf
docs: tests twoslash
posva Feb 7, 2024
4beea08
chore: nuxt
posva Feb 7, 2024
bfad3e0
chore: up pinia colada
posva Feb 7, 2024
9d46481
chore: setup playground
posva Feb 7, 2024
1002692
chor: up shiki
posva Feb 7, 2024
51c114e
docs: tests
posva Feb 7, 2024
7f7ed11
refactor!: rename refetch to reload
posva Feb 7, 2024
03a0368
refactor: up
posva Feb 7, 2024
8fde46e
test: debug internals
posva Feb 8, 2024
8f2f861
feat: working base colada loader
posva Feb 8, 2024
3d341ae
fix: delay setting the error
posva Feb 8, 2024
fa0c794
fix: avoid uncatchable rejection
posva Feb 8, 2024
f3750d4
chore: playground fixes
posva Feb 8, 2024
b2ae763
feat: track used params
posva Feb 8, 2024
ae37a8e
fix: allow errors outside of navigation
posva Feb 9, 2024
28aac39
chore: refactor
posva Feb 12, 2024
86d9cbc
test: more
posva Feb 12, 2024
b340997
chore: remove old fixmes
posva Feb 12, 2024
0695c63
chore: up deps
posva Feb 12, 2024
6e8497d
docs: updates
posva Feb 12, 2024
1bf9194
docs: add commande
posva Feb 12, 2024
f546bbf
chore: up pnpm
posva Feb 12, 2024
ee92ff7
docs: detailed search
posva Feb 12, 2024
a7529d9
docs: add more
posva Feb 13, 2024
567c5ee
chore: fix import suggestion
posva Feb 13, 2024
7ffa738
docs: twoslash
posva Feb 13, 2024
8bebcaf
docs: patch twoslash
posva Feb 13, 2024
be6f3b5
docs: update
posva Feb 13, 2024
4d20fa0
docs: more
posva Feb 13, 2024
d226cf9
fix(types): correctly extend client
posva Feb 13, 2024
627702f
docs: updates
posva Feb 13, 2024
e691a12
chore: up auto imports [skip ci]
posva Feb 13, 2024
58dbd6c
docs: fixes
posva Feb 13, 2024
fb63707
chore: repo settings
posva Feb 14, 2024
4d617a9
docs: add rfc wip
posva Feb 14, 2024
0cf1a16
chore: up playground
posva Feb 14, 2024
4caaeb8
docs: more
posva Feb 14, 2024
e043cba
refactor(runtime)!: rename `_defineBasicLoader` to `defineBasicLoader`
posva Feb 14, 2024
8094f62
refactor!: remove `setupLoaderGuard`
posva Feb 14, 2024
033386a
docs: notes
posva Feb 14, 2024
207330a
refactor: default commit to after-load
posva Feb 15, 2024
c94b38a
refactor: remove old loader exports
posva Feb 15, 2024
ced225b
chore: comments
posva Feb 15, 2024
af63f59
refactor: remove todos and fixes
posva Feb 15, 2024
885d854
docs: more types
posva Feb 15, 2024
aae0c70
perf: use a shallowRef for data
posva Feb 15, 2024
df7e87c
chore: note
posva Feb 15, 2024
fe3dd50
test: less flaky in CI
posva Feb 15, 2024
63a768f
feat: add pinia colada properties
posva Feb 15, 2024
0873b94
docs: colada loader
posva Feb 15, 2024
f0b7b58
refactor(data-loaders)!: rewrite of data loaders
posva Feb 15, 2024
425e8c3
refactor: rename folder
posva Feb 15, 2024
16a129b
docs: update rfc
posva Feb 16, 2024
ac30325
feat: upgrade pinia colada
posva Feb 20, 2024
b14b020
feat: allow lazy loaders with commit after-load
posva Feb 20, 2024
1635745
perf: use for of instead of forEach
posva Feb 20, 2024
656405e
feat: update colada loader
posva Feb 21, 2024
32db0d1
test: check warnings
posva Feb 21, 2024
fda7ac0
feat: simpler logger
posva Feb 21, 2024
37e7d74
chore: dedupe pinia colada
posva Feb 21, 2024
4cbc9b6
docs: rfc
posva Feb 21, 2024
30af445
docs: updates to implementations
posva Feb 21, 2024
0415b9e
refactor!: remove deprecated APIs
posva Feb 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/settings.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
repository:
homepage: https://uvr.esm.is
description: Next Generation file based typed routing for Vue Router
labels:
- name: 🐞 bug
color: ee0701
description: this isn't working as expected
- name: ✨ feature request
color: fbca04
description: a new feature request
- name: ⚡️ enhancement
color: a2eeef
description: improvement over an existing feature
- name: need repro
color: c9581c
description: the issue needs a reproduction for further investigation
- name: has workaround
color: 2139c4
description: has a temporary fix to get around the problem
- name: contribution welcome
color: 0e8a16
description: others are welcome to implement/fix this
- name: typescript
color: 3178c6
description: issue related to types
- name: 💬 discussion
color: 4935ad
description: topic that requires further discussion
- name: 📚 docs
color: 8be281
description: related to documentation
- name: good first issue
color: 7057ff
description: this should be manageable for new-comers
- name: help wanted
color: 008672
description: help in this issue is welcome
- name: wontfix
color: ffffff
description: this issue won't be fixed
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Set node
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: Setup
run: npm i -g @antfu/ni
Expand All @@ -36,7 +36,7 @@ jobs:

strategy:
matrix:
node: [16.x, 18.x]
node: [18.x, 20.x]
os: [ubuntu-latest, windows-latest, macos-latest]
fail-fast: false

Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,5 @@ dist

# IDE
.idea
/*.d.ts
!client.d.ts
tsconfig.vitest-temp.json
docs/.vitepress/cache
23 changes: 23 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Debug Current Test File",
"autoAttachChildProcesses": true,
"skipFiles": [
"<node_internals>/**",
"**/node_modules/**"
],
"program": "${workspaceRoot}/node_modules/vitest/vitest.mjs",
"args": [
"run",
"${relativeFile}"
],
"smartStep": true,
"console": "integratedTerminal"
}
]
}
4 changes: 2 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"prettier.enable": true,
"typescript.tsdk": "node_modules/typescript/lib",
"typescript.preferences.autoImportFileExcludePatterns": [
"vue-router",
"vue-router$",
],
"testing.automaticallyOpenPeekView": "never"
}
Loading