Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to add species routine to work with new updates #1671

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

andrewkern
Copy link
Member

patch to maintenance add_species routine. new updates to the way we pull data from ensembl broke this routine.

should close #1670

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (cb1550a) to head (ea970d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1671   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         136      136           
  Lines        4671     4671           
  Branches      470      470           
=======================================
  Hits         4664     4664           
  Misses          3        3           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petrelharp
Copy link
Contributor

LGTM, and it seems to fix the problem!

@petrelharp petrelharp merged commit 5762d28 into popsim-consortium:main Jan 24, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in maintenance add-species introduced in #1646
2 participants