Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial tracing docs #1731

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add initial tracing docs #1731

wants to merge 2 commits into from

Conversation

kralicky
Copy link
Contributor

No description provided.

@kralicky kralicky requested a review from a team as a code owner January 10, 2025 22:57
@kralicky kralicky requested review from rjbeers and removed request for a team January 10, 2025 22:57
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit 67c6b34
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/6793ad21fe76760008798861
😎 Deploy Preview https://deploy-preview-1731--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rjbeers
Copy link
Contributor

rjbeers commented Jan 22, 2025

@kralicky can you resolve the conflicts? This was based on the old docs organization before the larger refactor.

@kralicky kralicky force-pushed the kralicky/tracing-docs branch from d48239c to 3c04757 Compare January 22, 2025 18:56
Copy link
Contributor

@rjbeers rjbeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Some minor edits requested and we are missing the Zero setup instructions.

| tracing_provider | The name of the tracing provider. (e.g. Jaeger, Zipkin) | ✅ |
| tracing_sample_rate | Percentage of requests to sample in decimal notation. Default is `0.0001`, or .01% | ❌ |
</TabItem>
<TabItem value="Enterprise" label="Enterprise">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing a Zero tab.

| Name | Description | Default |
| :-- | :-- | :-- |
| [`OTEL_TRACES_EXPORTER`](https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#exporter-selection) | Trace exporter to be used. <br/> Valid values are `"otlp"` or `"none"` | `"none"` |
| [`OTEL_EXPORTER_OTLP_ENDPOINT`](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_endpoint) or <br/> [`OTEL_EXPORTER_OTLP_TRACES_ENDPOINT`](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_traces_endpoint) | See [Endpoint Configuration](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#endpoint-configuration). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the description, include a short description or example values and then the external link that you have now is fine below that as "For more details, see the OTEL documentation.", but we shouldn't send people external for basic info.

| :-- | :-- | :-- |
| [`OTEL_TRACES_EXPORTER`](https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#exporter-selection) | Trace exporter to be used. <br/> Valid values are `"otlp"` or `"none"` | `"none"` |
| [`OTEL_EXPORTER_OTLP_ENDPOINT`](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_endpoint) or <br/> [`OTEL_EXPORTER_OTLP_TRACES_ENDPOINT`](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_traces_endpoint) | See [Endpoint Configuration](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#endpoint-configuration). |
| [`OTEL_EXPORTER_OTLP_PROTOCOL`](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_protocol) or <br/> [`OTEL_EXPORTER_OTLP_TRACES_PROTOCOL`](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_traces_protocol) | See [Protocol Configuration](https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#protocol-configuration). <br/> Valid values are `"grpc"` or `"http/protobuf"`. <br/>If unset, Pomerium will attempt to determine the protocol based on the endpoint port number (the standard ports are 4317 for GRPC, 4318 for HTTP), otherwise it will default to `"http/protobuf"`. | (auto) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the external link below our own information, so users quickly get what they need, and if they need more, they keep reading and click the link.

@@ -16,109 +16,136 @@ import TabItem from '@theme/TabItem';

## Summary

Tracing tracks the progression of a single user request as it is handled by Pomerium.
Pomerium has comprehensive support for OpenTelemetry tracing, allowing detailed introspection into requests and authorization flows. You can use tracing to debug errors and latency issues in your applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first time we say OpenTelemetry, let's say "OpenTelemetry (OTel)" so later the OTel reference is clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants