Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint from 8.57.1 to 9.13.0 in /app #1184

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ jobs:

- name: Run ESLint
working-directory: ./app/
run: npm run lint
run: NODE_ENV=test npm run lint
13 changes: 4 additions & 9 deletions app/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const checkEnvironment = require('./functions/checkEnvironment.js');
const missingEnvVars = checkEnvironment();
if (missingEnvVars.length !== 0) {
throw new Error(
`Environment variables \` ${missingEnvVars.join('`, `')} missing`
`Environment variables \` ${missingEnvVars.join('`, `')} missing`,
);
}

Expand All @@ -33,20 +33,15 @@ const moduleExports = {
},
};

if (process.env.BUILD_ENV != 'local') {
moduleExports.sentry = {
hideSourceMaps: false,
};
}

const sentryWebpackPluginOptions = {
const sentryBuildOptions = {
// Additional config options for the Sentry Webpack plugin. Keep in mind that
// the following options are set automatically, and overriding them is not
// recommended:
// release, url, org, project, authToken, configFile, stripPrefix,
// urlPrefix, include, ignore

silent: true, // Suppresses all logs
hideSourceMaps: process.env.BUILD_ENV === 'local',

// For all available options, see:
// https://github.com/getsentry/sentry-webpack-plugin#options.
Expand All @@ -57,4 +52,4 @@ const sentryWebpackPluginOptions = {
module.exports =
process.env.BUILD_ENV == 'local'
? moduleExports
: withSentryConfig(moduleExports, sentryWebpackPluginOptions);
: withSentryConfig(moduleExports, sentryBuildOptions);
Loading
Loading