Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

Creation Default Constructor for ServerSocket #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Creation Default Constructor for ServerSocket #70

wants to merge 3 commits into from

Conversation

NulanNovias
Copy link
Collaborator 

modifié :         src/server_socket.cpp
modifié :         src/server_socket.h

Creation Default Constructor for ServerSocket
21c8303 
	modifié :         src/server_socket.cpp
	modifié :         src/server_socket.h
@NulanNovias NulanNovias added the enhancement New feature or request label Mar 8, 2021
@NulanNovias NulanNovias self-assigned this Mar 8, 2021
@NulanNovias NulanNovias linked an issue Mar 8, 2021 that may be closed by this pull request
ServerSocket default args constructor #29
Open
poloz-lab
poloz-lab suggested changes Mar 8, 2021
View reviewed changes
Copy link
Owner

@poloz-lab poloz-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be better to use the other constructor and specifying the default parameters like this:
ServerSocket::ServerSocket
:ServerSocket(5644125, 45452, Insqfgvfv)
{
}

And if we have to integrate that default constructor in the main.

NulanNovias added 2 commits March 9, 2021 13:30
Changes in default constructor call
c035736 
	modifié :         src/server_socket.cpp
	modifié :         src/server_socket.h
Moving default argument from H to CPP
0d72f7b 
	modifié :         src/server_socket.cpp
	modifié :         src/server_socket.h
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@poloz-lab poloz-lab poloz-lab requested changes

Assignees

@NulanNovias NulanNovias

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServerSocket default args constructor
2 participants
@NulanNovias @poloz-lab