Add support for Java 17 and update ASM to version 9.2 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Jul 18, 2021
| @@ -64,6 +64,7 @@ | |||
| <equals arg1="${-cleaned.specification.version}" arg2="14"/> | |||
| <equals arg1="${-cleaned.specification.version}" arg2="15"/> | |||
| <equals arg1="${-cleaned.specification.version}" arg2="16"/> | |||
| <equals arg1="${-cleaned.specification.version}" arg2="17"/> | |||
There was a problem hiding this comment.
I tried to follow ac754c4 as closely as possible.
| # It is provided here for reference, but can easily regenerated by executing from the source folder of forbidden-apis: | ||
| # $ ant generate-deprecated | ||
|
|
||
| # This file contains all public, deprecated API signatures in Java version 17 (extracted from build 17-ea). |
There was a problem hiding this comment.
Downloaded the OpenJDK early-access build today. Version details:
$ java -version
openjdk version "17-ea" 2021-09-14
OpenJDK Runtime Environment (build 17-ea+31-2664)
OpenJDK 64-Bit Server VM (build 17-ea+31-2664, mixed mode, sharing)
| # It is provided here for reference, but can easily regenerated by executing from the source folder of forbidden-apis: | ||
| # $ ant generate-internal | ||
|
|
||
| # This file contains all internal packages listed in Security.getProperty("package.access") of Java version 17 (extracted from build 17-ea). |
There was a problem hiding this comment.
^ Used the same version as mentioned above.
Comment on lines
+15
to
+19
| # These methods and classes should not be used by server classes (unsafe, no charset, no locale,...): | ||
|
|
||
| # We only include 16 for now. | ||
| # TODO: Scan Java 17 API for additional locale/charset/... violations! | ||
| @includeBundled jdk-unsafe-16 |
There was a problem hiding this comment.
Copied the jdk-unsafe-16.txt file and modified it accordingly.
|
Looks fine as a start! |
|
I will update the signatures files before release, but it is unlikely that something changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: