Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients: Don't filter countries in checkout by Stripe Connect #4737

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

birkjernstrom
Copy link
Member

@birkjernstrom birkjernstrom commented Dec 29, 2024

Bug due to bad (legacy) naming of config variable STRIPE_COUNTRIES. It reflects countries supported and enabled by us in Stripe Connect Express (for payouts), but sounds like available countries for Stripe overall. So it was used as a filter in checkout too.

Will rename the config variable to avoid future confusion, but wanted to get a quick fix out without turbo/next modifications of env variables.

Now our CountryPicker lists all countries by default in the world and only filters by Stripe Connect countries in case stripeConnectOnly is set to true

Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 8:37am
polar-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 8:37am

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 155.27 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/_not-found/page 362 B 155.62 KB 44.46% (+/- <0.01%)
/checkout/[clientSecret]/page 269.6 KB 424.87 KB 121.39% (🟡 +0.04%)
/(main)/login/magic-link/request/page 362 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/verify-email/page 363 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/(installation)/github/layout 362 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/[organization]/(header)/products/[productId]/page 191.33 KB 346.6 KB 99.03% (🟡 +0.04%)
/(main)/dashboard/layout 361 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/(landing)/page 494.31 KB 649.58 KB 185.59% (🟡 +0.04%)
/(main)/(topbar)/(backer)/purchases/page 362 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/dashboard/(create)/layout 362 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/dashboard/[organization]/storefront/page 372.81 KB 528.07 KB 150.88% (🟡 +0.04%)
/(main)/(landing)/(mdx)/blog/(header)/mitchell-hashimoto-joins-polar-as-an-advisor/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/(landing)/(mdx)/layout 362 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/(landing)/(mdx)/careers/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/better-pricing/page 33.54 KB 188.81 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/countries/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/customers/purchases/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/fees/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/merchant-of-record/compliance/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/payments-taxes/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/subscriptions/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/guides/page 362 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/docs/developers/guides/nextjs/page 34.02 KB 189.29 KB 54.08% (+/- <0.01%)
/(main)/docs/developers/guides/node/page 34.02 KB 189.29 KB 54.08% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-for-framer/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-init/page 34.02 KB 189.29 KB 54.08% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-migrate/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/sdk/python/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/sdk/github-actions/page 34.02 KB 189.29 KB 54.08% (+/- <0.01%)
/(main)/docs/developers/sdk/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/support/(mdx)/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/webhooks/events/page 361 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/products/page 362 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/account/page 200.76 KB 356.03 KB 101.72% (🟡 +0.04%)
/(main)/dashboard/[organization]/(header)/finance/account/page 148.56 KB 303.83 KB 86.81% (🟡 +0.04%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@birkjernstrom birkjernstrom merged commit a5d234e into main Dec 29, 2024
14 of 15 checks passed
@birkjernstrom birkjernstrom deleted the fix/checkout-countries branch December 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant