Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout: Improve discount form #4735

Merged
merged 3 commits into from
Dec 28, 2024
Merged

checkout: Improve discount form #4735

merged 3 commits into from
Dec 28, 2024

Conversation

birkjernstrom
Copy link
Member

  • clients: Reset discount state once input is emptied
  • clients: Prevent form submission on applying discount
  • clients: Improve UX for discounts apply/reset

Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 10:40pm
polar-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 10:40pm

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 155.27 KB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/_not-found/page 363 B 155.62 KB 44.46% (+/- <0.01%)
/checkout/[clientSecret]/page 269.47 KB 424.74 KB 121.35% (🟡 +0.02%)
/(main)/login/magic-link/authenticate/page 363 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/login/magic-link/request/page 361 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/(installation)/github/layout 360 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/[organization]/(header)/products/[productId]/page 191.2 KB 346.46 KB 98.99% (🟡 +0.02%)
/(main)/dashboard/layout 363 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/(landing)/page 494.18 KB 649.44 KB 185.55% (🟡 +0.02%)
/(main)/(topbar)/(backer)/purchases/page 363 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/dashboard/(create)/layout 363 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/dashboard/[organization]/storefront/page 372.67 KB 527.94 KB 150.84% (🟡 +0.02%)
/(main)/(landing)/(mdx)/layout 361 B 155.62 KB 44.46% (+/- <0.01%)
/(main)/(landing)/(mdx)/legal/privacy/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/(landing)/(mdx)/legal/terms/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/customers/purchases/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/fees/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/finance/payouts/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/payments-taxes/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/(mdx)/subscriptions/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/api/(mdx)/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/sdk/checkout-link/page 34.02 KB 189.29 KB 54.08% (+/- <0.01%)
/(main)/docs/developers/sdk/github-actions/page 34.03 KB 189.29 KB 54.08% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-for-framer/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-init/page 34.02 KB 189.29 KB 54.08% (+/- <0.01%)
/(main)/docs/developers/sdk/python/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/sdk/polar-migrate/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/developers/sdk/typescript/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/support/(mdx)/page 33.54 KB 188.8 KB 53.94% (+/- <0.01%)
/(main)/docs/support/(mdx)/faq/page 34.02 KB 189.29 KB 54.08% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant