This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 176
Convert SSOP-10_3.9x4.9mm_P1.00mm to generator, and add SOP-10_3.9x4.9mm_P1mm and NSOP-16_3.9x9.9mm_P1.27mm #645
Open
thatoddmailbox
wants to merge
4
commits into
pointhi:master
Choose a base branch
from
thatoddmailbox:ht42b534
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6f4ced6
Convert SSOP-10_3.9x4.9mm_P1.00mm to generator, and add SOP-10_3.9x4.…
thatoddmailbox 5248fde
Rename Package_SO:SSOP-10_3.9x4.9mm_P1.00mm to Package_SO:SSOP-10_3.9…
thatoddmailbox 7996195
Change pincount:d to pincount:s
thatoddmailbox 67c6c67
Fix issues caught by review
thatoddmailbox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
22 changes: 22 additions & 0 deletions
22
scripts/Packages/Package_Gullwing__QFP_SOIC_SO/size_definitions/nsop.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
FileHeader: | ||
library_Suffix: 'SO' | ||
device_type: 'NSOP' | ||
|
||
NSOP-16_3.9x9.9mm_P1.27mm: | ||
size_source: 'JEDEC MS-012AC, https://www.holtek.com/documents/10179/11842/HT42B534-xv110.pdf#page=15' | ||
body_size_x: 3.90 | ||
body_size_y: 9.90 | ||
overall_height: | ||
maximum: 1.75 | ||
|
||
overall_size_x: 6 | ||
lead_len: # from JEDEC (agrees with linked datasheet) | ||
minimum: 0.40 | ||
maximum: 1.27 | ||
lead_width: # from JEDEC (agrees with linked datasheet) | ||
minimum: 0.31 | ||
maximum: 0.51 | ||
|
||
pitch: 1.27 | ||
num_pins_x: 0 | ||
num_pins_y: 8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change all of those?
edit: I see that you commented on that. My first guess is that this is an unintended changed in the generator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can undo this change if you want, but then the script crashes on generating
soic.yaml
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: We are discussing this issue in #649