Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default configuration options #643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tahirmt
Copy link
Contributor

@tahirmt tahirmt commented Sep 22, 2022

Adding a set of public properties to use as default for all tests. Allows configuration of these properties on a global level

  • precision
  • perceptualPrecision
  • timeout
  • snapshotSubdirectory to allow someone to change the default __Snapshots__ folder. Useful if you need to create multiple sets of snapshots depending on conditions.
  • snapshotDirectory

Motivation

Providing an easy way to configure things like perceptualPrecision introduced in #424 when someone wants to apply it globally without having to write a ton of overrides. All of these options could be made configurable through the use of a plugin by writing a ton of extensions and passed in values. Snapshot location might be the toughest to do because we would need to reimplement the default behavior of a directory name at the same path as the file.

My work is similar to #641 but it allows for more customization

@tahirmt tahirmt force-pushed the add-global-configuration branch from b45e74d to 9ea175a Compare September 22, 2022 02:15
@tahirmt tahirmt force-pushed the add-global-configuration branch from 9ea175a to f0f7374 Compare November 24, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant