Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurational dependencies #8

Merged
merged 6 commits into from
Jan 8, 2025
+59 −0
Merged

Configurational dependencies #8

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
193a856
Configurational dependencies
zkochan Dec 26, 2024
7a4335b
Add note about directory name
zkochan Dec 26, 2024
008138c
Update text/0004-configurational-dependencies.md
zkochan Dec 26, 2024
73eaab8
Apply wording improvements
zkochan Dec 26, 2024
9ac01dc
Mention templates
zkochan Dec 26, 2024
0114c3d
Specify the directory where config deps will be placed
zkochan Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions text/0004-configurational-dependencies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ These dependencies will be installed as early as possible in order to be able to

## Prior Art

There was a big RFC by Brandon Cheng about a much more powerful system using [templates](https://github.com/pnpm/rfcs/pull/3), which was rejected.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new system here targeting just pnpm specific settings is a lot easier to understand. 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't remember why exactly it was rejected.


## Unresolved Questions and Bikeshedding

{{Write about any arbitrary decisions that need to be made (syntax, colors, formatting, minor UX decisions), and any questions for the proposal that have not been answered.}}
Expand Down