Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correct the name of an error #184

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

KSXGitHub
Copy link
Contributor

No description provided.

@KSXGitHub KSXGitHub requested review from zkochan and anonrig November 6, 2023 10:32
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac9dbbd) 87.18% compared to head (55b0232) 87.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   87.18%   87.11%   -0.08%     
==========================================
  Files          56       56              
  Lines        2824     2824              
==========================================
- Hits         2462     2460       -2     
- Misses        362      364       +2     
Files Coverage Δ
crates/store-dir/src/index_file.rs 93.54% <100.00%> (ø)
crates/tarball/src/lib.rs 89.72% <ø> (-1.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 6, 2023

Micro-Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.01     10.8±0.79ms   403.0 KB/sec    1.00     10.7±0.88ms   405.1 KB/sec

Copy link

github-actions bot commented Nov 6, 2023

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command Mean [ms] Min [ms] Max [ms] Relative
pacquet@HEAD 211.7 ± 14.2 187.4 224.6 1.01 ± 0.12
pacquet@main 209.7 ± 20.0 177.2 234.9 1.00
BENCHMARK_REPORT.json
{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 0.21173010954727278,
      "stddev": 0.014223234090670821,
      "median": 0.22158591082000004,
      "user": 0.07003305636363637,
      "system": 0.1317864472727273,
      "min": 0.18737509082000003,
      "max": 0.22455504182000002,
      "times": [
        0.21302193082000004,
        0.22210243282000003,
        0.18737509082000003,
        0.22277136382,
        0.19885980182000002,
        0.22242014782000002,
        0.22167941482000003,
        0.20579830882000003,
        0.22455504182000002,
        0.22158591082000004,
        0.18886176082000003
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 0.2096618834563637,
      "stddev": 0.01998938458100021,
      "median": 0.20887295782000004,
      "user": 0.08243905636363637,
      "system": 0.12627190181818182,
      "min": 0.17722095082000003,
      "max": 0.23492311582000003,
      "times": [
        0.20593572682000003,
        0.23492311582000003,
        0.19954114282000002,
        0.22335840082000002,
        0.19650640782000003,
        0.22200534082000004,
        0.22382902282000003,
        0.20887295782000004,
        0.18001757382000003,
        0.23407007782000003,
        0.17722095082000003
      ],
      "exit_codes": [
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0,
        0
      ]
    }
  ]
}

@zkochan zkochan merged commit 6b00165 into main Nov 6, 2023
12 of 13 checks passed
@zkochan zkochan deleted the refactor-correct-error-type-name branch November 6, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants