Skip to content

Commit

Permalink
docs: note about hardlink nuance for future impl (#175)
Browse files Browse the repository at this point in the history
  • Loading branch information
KSXGitHub authored Nov 2, 2023
1 parent 782a1ab commit 78e8410
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion crates/package-manager/src/link_file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,16 @@ pub fn link_file(source_file: &Path, target_link: &Path) -> Result<(), LinkFileE
})?;
}

// TODO: add hardlink (https://github.com/pnpm/pacquet/issues/174)
// NOTE: do not hardlink packages with postinstall

reflink_copy::reflink_or_copy(source_file, target_link).map_err(|error| {
LinkFileError::CreateLink {
from: source_file.to_path_buf(),
to: target_link.to_path_buf(),
error,
}
})?; // TODO: add hardlink
})?;

Ok(())
}

0 comments on commit 78e8410

Please sign in to comment.