-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse https github URL with branch name with slash #2
base: master
Are you sure you want to change the base?
Parse https github URL with branch name with slash #2
Conversation
pnpm uses FYI: https://github.com/pnpm/pnpm/blob/main/package.json#L72 However, it may be better way to use original |
or use git-url-parse instead of hosted-git-info
git-url-parse can parse github shortcut refs
but no... git-url-parse fails to parse github branch urls and github commit urls
feature request: IonicaBizau/git-url-parse#161 |
Ticket
Refs: pnpm/pnpm#5684
Details
To support pnpm/pnpm#5684 feature, we should take two actions.
First, we should enable
hosted-git-info
, which pnpm uses to parse https://github.com URL, to parse github URL with branch name with slash and github URL with pull_request.Second, we should fix pnpm itself not to reckon github URL with branch name or github URL with pull_request as tarball URL. (https://github.com/pnpm/pnpm/blob/main/resolving/tarball-resolver/src/index.ts#L33)
This Pull Request is to take the first action. Of course, we can support pnpm/pnpm#5684 without fixing
hosted-git-info
by arranging github URL before passing github URL intohosted-git-info
in pnpm itself, but I think we should not do this because it would be more simple and better to consolidate the responsibility into git-hosted-info to parse github URL.