-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support removing attributes from animated elements #2293
Conversation
🦋 Changeset detectedLatest commit: 66bf995 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we can evaluate on this being the right thing to do properly, can we add a couple of test cases to animated.test.tsx
that shows this working please? :)
I suppose right now it's impossible for a spring value to even be |
@LoganDark can you rebase this please? :) |
oh oops I didn't realize I had another PR open, lmao, one moment |
looks like I can't reopen this without making a new one so I will make a new one |
Why
inert
does not acceptinert=''
,inert='false'
,inert='undefined'
or etc. The attribute must be entirely removed in order to enable the element again.disabled
works the same way.What
If a value resolves to
undefined
(notnull
orfalse
or otherwise) its attribute will now be entirely removed.Checklist