Remove auto-tag creation

pmndrs · May 30, 2024 · 5ad27f9 · 5ad27f9
1 parent 692d248
commit 5ad27f9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 15 deletions.
diff --git a/packages/scheduler/src/class/scheduler.test.ts b/packages/scheduler/src/class/scheduler.test.ts
@@ -101,6 +101,8 @@ describe('Scheduler Class', () => {
         const group1 = Symbol();
         const schedule = new Scheduler();
 
+        schedule.createTag(group1);
+
         schedule.add(aFn, { id: 'A', tag: group1 });
         schedule.add(bFn, { id: 'B', after: 'A', tag: group1 });
 
@@ -116,6 +118,8 @@ describe('Scheduler Class', () => {
         const group1 = Symbol();
         const schedule = new Scheduler();
 
+        schedule.createTag(group1);
+
         schedule.add(aFn, { id: 'A', tag: group1 });
         schedule.add(bFn, { id: 'B', after: 'A', tag: group1 });
         schedule.add(cFn, { id: 'C', before: group1 });
@@ -135,6 +139,8 @@ describe('Scheduler Class', () => {
         const group1 = Symbol();
         const schedule = new Scheduler();
 
+        schedule.createTag(group1);
+
         schedule.add(aFn, { id: 'A', tag: group1 });
         schedule.add(bFn, { id: 'B', after: 'A', tag: group1 });
 

diff --git a/packages/scheduler/src/class/scheduler.ts b/packages/scheduler/src/class/scheduler.ts
@@ -24,21 +24,6 @@ export class Scheduler {
     }
 
     add(runnable: Runnable<any>, options?: OptionsObject): Scheduler {
-        // If there are tags, check if they exist, otherwise create them.
-        if (options?.tag) {
-            if (Array.isArray(options.tag)) {
-                options.tag.forEach((tag) => {
-                    if (!this.tags.has(tag)) {
-                        createTag(this, tag);
-                    }
-                });
-            } else {
-                if (!this.tags.has(options.tag)) {
-                    createTag(this, options.tag);
-                }
-            }
-        }
-
         const optionsFns = createOptionsFns(options);
         add(this, runnable, ...optionsFns);