Fixed entity spawn position

[leolee3914]

PocketMine-MP/src/entity/Entity.php

Line 791 in 3a2d0d7

$this->getOffsetPosition($this->location),

Related issues & PRs

Changes

API changes

Behavioural changes

Backwards compatibility

Follow-up

Tests

[leolee3914]

PrimedTNT spawns without offset position

2025-02-28_20-03-43_Fri-wth-no-offset.mp4

PrimedTNT spawns with offset position

2025-02-28_20-00-30_Fri-with-offset.mp4

seems the position should only be fixed on AddActorPacket
Human->sendSpawnPacket() for players using AddPlayerPacket has no offset issue
i am not sure for ItemEntity because the offset is small

[dktapps]

This should be tested with entities such as zombies and villagers

[leolee3914]

zombie and villager have zero offset position. nothing can be tested

[dktapps]

Strange this hasn't been picked up on before. Do you know if it changed in a recent version?

[leolee3914]

i think this issue has existed for many years
nobody noticed it because Entity->broadcastMovement() will correct the position shortly

[dktapps]

I doubt that. The TNT position error is pretty obvious, someone would've noticed.