-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocks interfaces for commons properties #6639
base: minor-next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the names of the interfaces are too verbose. I understand why (e.g. WoodType
would conflict with the WoodType
enum), but I don't like it much.
May be replace |
The aim is also to follow the name of the trait with the name of the corresponding interface, I think. If we were to rename these interfaces, it would probably make more sense to rename the trait accordingly. |
I'd personally favour e.g. |
In my opinion, syntax |
yeah I consider that but I don't really like any of the alternatives |
Perhaps for wood specifically we can follow copper's lead with |
So you want i remove |
Yeah, that's where I'm leaning right now. Welcome to suggest better alternatives. |
Related issues & PRs
Add #6161
Changes
API changes
Add:
AgeableInterface
AnalogRedstoneSignalEmitterInterface
ColoredInterface
CoralTypeInterface
LightableInterface
MultiFacingInterface
PillarRotationInterface
PoweredByRedstoneInterface
SignLikeRotationInterface
SingleFacingInterface
WoodTypeInterface
Behavioural changes
Backwards compatibility
No BC Break
Follow-up
Tests