run_qemu.sh: drop dracut --filesystems="xfs ext4" parameter #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of the --filesystems= parameter is a bit counter-intuitive:
it's designed to _reduce_ the size of the initrd by excluding all
modules except the ones given.
```
man dracut
--filesystems <list of filesystems>
Specify a space-separated list of kernel filesystem modules
to EXCLUSIVELY include in the generic initramfs.
```
Emphasis mine.
So, the previous "xfs ext4" argument could prevent someone with another
filesystem module to boot.
Worse: if CONFIG_XFS_FS is false, then passing "xfs ext4" prints the
following warning:
```
dracut-install: Failed to find module 'xfs'
dracut[E]: FAILED: /usr/lib/dracut/dracut-install -D
/var/tmp/dracut.eRkJZX/initramfs -N ^nfit$|^libnvdimm$|^nd_pmem$
--kerneldir ./qbuild/mkosi.extra/lib/modules/6.12.0-dirty -m xfs ext4
```
Then, dracut does not include ext4 either and keeps running! So, users
with CONFIG_EXT4_FS=m can't boot either!
Most users probably use built-in drivers which means they never
notice.
Signed-off-by: Marc Herbert <[email protected]>
stellarhopper
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the --filesystems= parameter is a bit counter-intuitive: it's designed to reduce the size of the initrd by excluding all modules except the ones given.
Emphasis mine.
So, the previous "xfs ext4" argument could prevent someone with another filesystem module to boot.
Worse: if CONFIG_XFS_FS is false, then passing "xfs ext4" prints the following warning:
Then, dracut does not include ext4 either and keeps running! So, users with CONFIG_EXT4_FS=m can't boot either!
Most users probably use built-in drivers which means they never notice.