-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: introduce the lower limit parameter #5909
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5909 +/- ##
==========================================
+ Coverage 69.02% 71.01% +1.98%
==========================================
Files 131 131
Lines 19668 19172 -496
Branches 3257 3193 -64
==========================================
+ Hits 13576 13615 +39
+ Misses 6092 5557 -535 |
031cf99
to
5cf12c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
utils/call_stacks_analysis/generate_call_stacks.py
line 25 at r1 (raw file):
PARSER.add_argument('-w', '--white-list') # XXX PARSER.add_argument('-d', '--dump', action='store_true', help='Dump debug files') PARSER.add_argument('-l', '--lower-limit', type=int, default=0,
Let's start using it ASAP to avoid the generation of a huge output.
Suggestion:
PARSER.add_argument('-l', '--lower-limit', type=int, default=128,
utils/call_stacks_analysis/generate_call_stacks.py
line 327 at r1 (raw file):
# are needed when the user wants to list all API calls making # use of a particular function in their call stacks. dump(small_enough, 'call_stacks_excluded', True)
Suggestion:
dump(small_enough, 'call_stacks_below_limit', True)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
5cf12c6
to
eb8629f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @grom72 and @osalyk)
utils/call_stacks_analysis/generate_call_stacks.py
line 25 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Let's start using it ASAP to avoid the generation of a huge output.
This limit reduces the final number of call stacks by 0.2%. 🤣
I think we have to do better. Find a reasonable value and put it as default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
eb8629f
to
bb135f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @grom72 and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Signed-off-by: Jan Michalski <[email protected]>
This change is