Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: remove obsolete headers files #5904

Closed
wants to merge 1 commit into from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Nov 8, 2023

This change is Reviewable

@grom72 grom72 added the no changelog Add to skip the changelog check on your pull request label Nov 8, 2023
@grom72 grom72 force-pushed the remove-daxctl-header branch from daee4cb to 154c7b8 Compare November 13, 2023 09:23
@grom72 grom72 requested review from janekmi and osalyk November 16, 2023 05:54
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8d647a) 70.05% compared to head (74b89d6) 70.04%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5904      +/-   ##
==========================================
- Coverage   70.05%   70.04%   -0.02%     
==========================================
  Files         133      133              
  Lines       19559    19559              
  Branches     3263     3263              
==========================================
- Hits        13702    13700       -2     
- Misses       5857     5859       +2     

@grom72 grom72 added the obsolete-src Obsolete source code label Nov 16, 2023
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@grom72 grom72 added this to the 2.0.1 milestone Nov 22, 2023
@janekmi janekmi modified the milestones: 2.0.1, 2.0.2 Nov 23, 2023
@janekmi janekmi modified the milestones: 2.1.0, 2.x Feb 8, 2024
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 force-pushed the remove-daxctl-header branch from 154c7b8 to 74b89d6 Compare February 15, 2024 22:50
@grom72 grom72 closed this Feb 29, 2024
@grom72 grom72 deleted the remove-daxctl-header branch February 29, 2024 10:19
@grom72 grom72 restored the remove-daxctl-header branch March 12, 2024 17:53
@grom72 grom72 deleted the remove-daxctl-header branch March 12, 2024 18:23
@grom72 grom72 restored the remove-daxctl-header branch March 12, 2024 18:25
@grom72 grom72 deleted the remove-daxctl-header branch March 12, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request obsolete-src Obsolete source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants