phpstan lvl 1

ajax/reorder.php

@@ -44,6 +44,9 @@
 $old_order    = (int)$_POST['old_order'];
 $new_order    = (int)$_POST['new_order'];
 
+/** @var DBmysql $DB */
+global $DB;
+
 // Retrieve id of field to update
 $field_iterator = $DB->request(
     [

composer.json

@@ -6,6 +6,7 @@
     "require-dev": {
         "glpi-project/tools": "^0.6",
         "php-parallel-lint/php-parallel-lint": "^1.3",
+        "phpstan/phpstan": "^1.10",
         "squizlabs/php_codesniffer": "^3.6"
     },
     "config": {

front/commondropdown.form.php

@@ -30,7 +30,7 @@
 
 include "../../../inc/includes.php";
 if (preg_match('/[a-z]/i', $_REQUEST['ddtype']) !== 1) {
-    throw new \RuntimeException(sprintf('Invalid itemtype "%"', $_REQUEST['ddtype']));
+    throw new \RuntimeException(sprintf('Invalid itemtype "%1$s"', $_REQUEST['ddtype']));
 }
 $path = PLUGINFIELDS_FRONT_PATH . '/' . $_REQUEST['ddtype'] . '.form.php';
 require_once $path;

front/commondropdown.php

@@ -30,7 +30,7 @@
 
 include "../../../inc/includes.php";
 if (preg_match('/[a-z]/i', $_REQUEST['ddtype']) !== 1) {
-    throw new \RuntimeException(sprintf('Invalid itemtype "%"', $_REQUEST['ddtype']));
+    throw new \RuntimeException(sprintf('Invalid itemtype "%1$s"', $_REQUEST['ddtype']));
 }
 $path = PLUGINFIELDS_FRONT_PATH . '/' . $_REQUEST['ddtype'] . '.php';
 require_once $path;

hook.php

@@ -252,6 +252,7 @@ function plugin_fields_rule_matched($params = [])
 
     switch ($params['sub_type']) {
         case "PluginFusioninventoryTaskpostactionRule":
+            /** @phpstan-ignore-next-line */
             $agent = new PluginFusioninventoryAgent();
 
             if (isset($params['input']['plugin_fusioninventory_agents_id'])) {

inc/container.class.php

@@ -474,6 +474,8 @@ public static function getSpecificValueToDisplay($field, $values, array $options
                 }
                 return $obj;
         }
+
+        return '';
     }
 
 
@@ -487,7 +489,7 @@ public function getValueToSelect($field_id_or_search_options, $name = '', $value
                 return Dropdown::showFromArray($name, self::getTypes(), $options);
             case $this->getTable() . '.itemtypes':
                 $options['display'] = false;
-                return Dropdown::showFromArray($name, self::getItemtypes(), $options);
+                return Dropdown::showFromArray($name, self::getItemtypes(false), $options);
         }
 
         return parent::getValueToSelect($field_id_or_search_options, $name, $values, $options);
@@ -1114,6 +1116,8 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
             }
             return $tabs_entries;
         }
+
+        return '';
     }
 
 
@@ -1133,6 +1137,8 @@ public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $
                 return PluginFieldsField::showForTabContainer($data['id'], $item);
             }
         }
+
+        return true;
     }
 
     /**
@@ -1576,6 +1582,8 @@ public static function postItemAdd(CommonDBTM $item)
             }
             return $item->input = [];
         }
+
+        return true;
     }
 
     /**
@@ -1601,6 +1609,8 @@ public static function preItemUpdate(CommonDBTM $item)
             }
             return $item->input = [];
         }
+
+        return true;
     }
 
 

inc/containerdisplaycondition.class.php

@@ -198,6 +198,8 @@ private static function getItemtypesForContainer(int $container_id): array
     {
         global $DB;
 
+        $results = [];
+
         $iterator = $DB->request([
             'SELECT' => ['itemtypes'],
             'FROM'   => PluginFieldsContainer::getTable(),
@@ -212,9 +214,9 @@ private static function getItemtypesForContainer(int $container_id): array
             foreach ($itemtypes as $itemtype) {
                 $results[$itemtype] = $itemtype::getTypeName();
             }
-            return $results;
         }
-        return [];
+
+        return $results;
     }
 
 
@@ -551,6 +553,8 @@ public function showForm($ID, array $options = [])
                 : self::removeBlackListedOption(Search::getOptions($this->fields['itemtype']), $this->fields['itemtype']),
         ];
         TemplateRenderer::getInstance()->display('@fields/forms/container_display_condition.html.twig', $twig_params);
+
+        return true;
     }
 
     public function getCloneRelations(): array

inc/field.class.php

@@ -272,7 +272,7 @@ public function prepareInputForAdd($input)
 
             //reject adding for same dropdown on same bloc
             if (!empty($found)) {
-                Session::AddMessageAfterRedirect(__("You cannot add same field 'dropdown' on same bloc", 'fields', false, ERROR));
+                Session::AddMessageAfterRedirect(__("You cannot add same field 'dropdown' on same bloc", 'fields'), false, ERROR);
                 return false;
             }
 
@@ -676,8 +676,8 @@ public function showForm($ID, $options = [])
     {
         $rand = mt_rand();
 
+        $container = new PluginFieldsContainer();
         if (isset($options['parent_id']) && !empty($options['parent_id'])) {
-            $container = new PluginFieldsContainer();
             $container->getFromDB($options['parent_id']);
         } else if (
             isset($options['parent'])
@@ -697,7 +697,7 @@ public function showForm($ID, $options = [])
         }
 
         $this->initForm($ID, $options);
-        $this->showFormHeader($ID, $options);
+        $this->showFormHeader($options);
 
         echo "<tr>";
         echo "<td>" . __("Label") . " : </td>";
@@ -774,6 +774,8 @@ public function showForm($ID, $options = [])
         echo "</tr>";
 
         $this->showFormButtons($options);
+
+        return true;
     }
 
     public static function showForTabContainer($c_id, $item)

inc/inventory.class.php

@@ -39,7 +39,8 @@ public static function updateInventory($params = [])
             $availaibleItemType = ["Computer","Printer","NetworkEquipment"];
             foreach (array_keys($params['inventory_data']) as $itemtype) {
                 if (in_array($itemtype, $availaibleItemType)) {
-                    //retrive items id switch itemtype
+                    $items_id = 0;
+                    //retrieve items id switch itemtype
                     switch ($itemtype) {
                         case Computer::getType():
                              $items_id = $params['computers_id'];
@@ -57,6 +58,7 @@ public static function updateInventory($params = [])
                     if ($itemtype == Computer::getType()) {
                         //load inventory from DB because
                         //FI not update XML file if computer is not update
+                        /** @phpstan-ignore-next-line  */
                         $db_info = new PluginFusioninventoryInventoryComputerComputer();
                         if ($db_info->getFromDBByCrit(['computers_id' => $items_id])) {
                             $arrayinventory = unserialize(gzuncompress($db_info->fields['serialized_inventory']));
@@ -68,6 +70,7 @@ public static function updateInventory($params = [])
                         //Load XML file because FI always update XML file and don't store inventory into DB
                         $file = self::loadXMLFile($itemtype, $items_id);
                         if ($file !== false) {
+                              /** @phpstan-ignore-next-line  */
                               $arrayinventory = PluginFusioninventoryFormatconvert::XMLtoArray($file);
                             if (isset($arrayinventory['CUSTOM'])) {
                                 self::updateFields($arrayinventory['CUSTOM']['CONTAINER'], $itemtype, $items_id);
@@ -108,6 +111,7 @@ public static function loadXMLFile($itemtype, $items_id)
         }
 
         //Check if the file exists with the .xml extension (new format)
+        /** @phpstan-ignore-next-line  */
         $file = PLUGIN_FUSIONINVENTORY_XML_DIR . strtolower($itemtype) . "/" . $folder . "/" . $items_id;
         if (file_exists($file . '.xml')) {
             $file .= '.xml';

inc/labeltranslation.class.php

@@ -129,6 +129,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
     public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
     {
         self::showTranslations($item);
+        return true;
     }
 
     /**

inc/profile.class.php

@@ -126,6 +126,7 @@ public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $
         echo "</tr>";
         echo "</table></div>";
         Html::closeForm();
+        return true;
     }
 
     public static function updateProfile($input)

inc/statusoverride.class.php

@@ -412,5 +412,6 @@ public function showForm($ID, array $options = [])
             'container_fields'    => self::getFieldsChoiceForContainer($container_id),
         ];
         TemplateRenderer::getInstance()->display('@fields/forms/status_override.html.twig', $twig_params);
+        return true;
     }
 }

inc/toolbox.class.php

@@ -321,6 +321,7 @@ public static function getGlpiItemtypes(): array
         $plugin = new Plugin();
         if ($plugin->isActivated('genericobject') && method_exists('PluginGenericobjectType', 'getTypes')) {
             $go_itemtypes = [];
+            /** @phpstan-ignore-next-line  */
             foreach (array_keys(PluginGenericobjectType::getTypes()) as $go_itemtype) {
                 if (!class_exists($go_itemtype)) {
                     continue;

phpstan.neon

@@ -0,0 +1,17 @@
+parameters:
+    parallel:
+        maximumNumberOfProcesses: 2
+    level: 1
+    bootstrapFiles:
+        - ../../inc/based_config.php
+        - setup.php
+    paths:
+        - inc
+        - front
+        - ajax
+        - hook.php
+    scanDirectories:
+        - ../../inc
+        - ../../src
+    stubFiles:
+        - ../../stubs/glpi_constants.php