Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/clean code #528

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Task/clean code #528

merged 4 commits into from
Jun 3, 2022

Conversation

cedric-anne
Copy link
Contributor

  1. Drop dead code in container install() method
  2. Move dropdown field SQL name handling at right place
  3. Remove migration dead code
  4. Drop dead code and fix IDE warnings

@cedric-anne cedric-anne self-assigned this Jun 3, 2022
@cedric-anne cedric-anne mentioned this pull request Jun 3, 2022
Closed
@cedric-anne cedric-anne added this to the 1.15.4 milestone Jun 3, 2022
@cedric-anne cedric-anne merged commit 5691edd into pluginsGLPI:develop Jun 3, 2022
@cedric-anne cedric-anne deleted the task/clean-code branch June 3, 2022 09:47
@cedric-anne cedric-anne modified the milestones: 1.15.4, 1.16.0 Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

@stonebuzz stonebuzz Awaiting requested review from stonebuzz

Assignees

@cedric-anne cedric-anne

Labels
task
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cedric-anne @AdrienClairembault