-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename $_SESSION key from 'plugins' to 'glpi_plugins' #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced by this solution, approvalByMail
initializes a user session when the user approves a validation request.
public static function initSession(User $user): void
{
static::$old_session_id = Session::getLoginUserID();
$auth = new Auth();
$auth->user = $user;
$auth->auth_succeded = true;
Session::init($auth);
}
and the Escalade
plugin is designed to work in these conditions (from plugin_init_escalade()
)
if ((isset($_SESSION['glpiID']) || isCommandLine()) && Plugin::isPluginActive('escalade')) {
}
You should check whether the ApprovalByMail plugin initializes the user session correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good for me,
can you ask the client to confirm that it is working correctly by giving it the patch?
(you'll have to tell it to clean the glpi cache).
and adapt changelog =) |
CHANGELOG.md
Outdated
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
- Redirect users without ticket rights after escalation. | |||
- Fix private task added when ticket mandatory fields are not filled | |||
- fix: rename $_SESSION key from 'plugins' to 'glpi_plugins' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- fix: rename $_SESSION key from 'plugins' to 'glpi_plugins' | |
- Ensure plugin works seamlessly in external contexts (e.g., from plugins) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CHANGELOG, the descriptions must be functional, not technical.
Checklist before requesting a review
Please delete options that are not relevant.
Description