Implement phpstan 5 #399
Open
Implement phpstan 5 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
requested changes
Jun 5, 2024
Rom1-B
requested changes
Jun 6, 2024
Rom1-B
requested changes
Jun 10, 2024
Rom1-B
reviewed
Jun 10, 2024
Rom1-B
reviewed
Jun 10, 2024
Rom1-B
approved these changes
Jun 12, 2024
Co-authored-by: Stanislas <[email protected]>
Co-authored-by: Romain B. <[email protected]>
Rom1-B
requested changes
Jan 30, 2025
inc/backendcsv.class.php
Outdated
Comment on lines
82
to
83
| * @param mixed $fic | ||
| * @param mixed $data |
There was a problem hiding this comment.
mixed should be avoided, as it gives no indication of what is expected and on higher levels of PHPstan, it raises an error.
$fic doesn't seem to be used, so it's not important for this one. See if it can be removed, but in another dedicated PR.
Co-authored-by: Romain B. <[email protected]>
Co-authored-by: Romain B. <[email protected]>
Rom1-B
requested changes
Jan 30, 2025
Co-authored-by: Romain B. <[email protected]>
Co-authored-by: Romain B. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.