Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prelude: fix types of Array primitives; add Option.join #95

Merged
merged 7 commits into from
Nov 21, 2023

Conversation

siddharth-krishna
Copy link
Collaborator

No description provided.

@@ -650,6 +660,18 @@ module Base
| None -> default
};

// TODO fix parser and re-introduce this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor) we need this on the PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not super easy to do, so I'll do it in a future PR

Copy link
Contributor

@mirko-plowtech mirko-plowtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! despite doc typo.

@siddharth-krishna siddharth-krishna enabled auto-merge (squash) November 21, 2023 08:40
@siddharth-krishna siddharth-krishna merged commit ecd7f58 into main Nov 21, 2023
1 check passed
@siddharth-krishna siddharth-krishna deleted the sidk-array-types branch November 21, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants