Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript example #290

Closed
wants to merge 2 commits into from

Conversation

FDiskas
Copy link
Contributor

@FDiskas FDiskas commented Nov 3, 2021

closes #192

Make sure you have installed ts-node befor using it.

@FDiskas
Copy link
Contributor Author

FDiskas commented Nov 3, 2021

I deleted plopfile.js it is not needed. plopjs tries ts-node without any additional configuration or compilation. ts-node parses ts files on the fly so plopjs understands it out of the box.

@ivanoats
Copy link

ivanoats commented Nov 3, 2021

Is it possible to review the README with only the sections you modified? It would be easier to review if it didn't modify the whole file.

@FDiskas
Copy link
Contributor Author

FDiskas commented Nov 3, 2021

I'm sorry,
I added section from line 608. At the very bottom.

@crutchcorn
Copy link
Member

Ahh @FDiskas that's probably my bad. I didn't realize the autoformatter ran on the README. Don't worry about it, I can fix the diffing when I'm ready to review (just started vacation w/ a 14 hr drive. Will try to review in the next few days from my laptop)

@FDiskas
Copy link
Contributor Author

FDiskas commented Nov 4, 2021

Thank you. Drive safe and come back alive :)
Lucky "bastard" :) I already forgot how vacation looks like :D

@crutchcorn
Copy link
Member

Just as a heads up @FDiskas - I'm releasing plop@3 really really soon (this weekend at the latest). It inherently changes how examples are listed (they're now tied to tests).

This won't make it into that initial merge, but the good news is that we can now not only have an example for TS usage, but include it in our tests!

I'll be taking this PR post-3 launch and turning it into a test. Huge thanks for the PR! I'll make sure to cherry-pick to give proper credit in commit history :)

This was referenced Nov 25, 2021
@crutchcorn
Copy link
Member

Closing, since we now have a properly documented TS example usage here: https://github.com/plopjs/plop/tree/main/packages/plop/tests/examples/typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document tsconfig File for Plop Usage in TS
3 participants