Fix Unnecessary Renders of Blocks in Edit Mode #6639
Draft
+283
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
iFlameing
changed the title
iFlameing
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a good idea or bad I don't know but still, I am trying to figure it out.
This is just my playground for improving the overall performance of volto in Edit mode. we are re-rendering lot's of time which we shouldn't. As the react take very small time in re-rendering and overall app feels fast but as the page grows it might lead to performance.
First finding hovered props is re-rendering the whole block whenever you hover on one. just removed the hovered props from the blocks and you are good.
We need to discuss how we use properties, navroot and nav root. Continue to investigate further.