-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for protected vocabulary in endpoint 'vocabularies'. #1287
base: main
Are you sure you want to change the base?
Conversation
@ksuess thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@ksuess Genius! That's how it should work. I love it. I would just merge this! Then we can go further:
Finally a clean solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome!
Sorry for being picky, I checked quickly and in the cell phone, but shouldn't we also take care of the 401 use case from a formal point of view?
May I propose to close this PR.
Thanks for the kind feedback and sorry for the noise. |
In midterm we can maybe think of a Plone Vocabulary Registry that can deal with permission protection. A first try: plone/plone.app.vocabularies#69 |
Fix 1286