feat: update .Header.Resources to a string array #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Muraoka <[email protected]>
tapih
changed the title
Signed-off-by: Hiroshi Muraoka <[email protected]>
jalseth
approved these changes
Jul 6, 2024
|
Thanks for the PR! Please fix the tests and we can get this merged. |
Signed-off-by: Hiroshi Muraoka <[email protected]>
Signed-off-by: Hiroshi Muraoka <[email protected]>
tapih
force-pushed
the
tapih/resources-array
branch
from
2a248bf to
44688dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Resources:** {{ .Header.Resources }}is hard to read when many resources are specified because they are space separated.This PR proposes replacing
.Header.Resourceswith a string array.