Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Erlang:
25.2
Elixir:
1.14.2
Phoenix:
1.7.0-rc.0
Using
ecto_sql 3.9.2
and plausible versions ofclickhousex
/clickhouse_ecto
on a fresh phoenix 1.7 appmix ecto.create
would throw an error:Changes
Looking through
ecto_sql
, noticed that it's ensuring the deps are startedAdded these to the top of
run_query/2
and now the mix tasks are working as expected.Concerns
Not entirely sure what the impact might be on existing apps but Application.ensure_all_started/2 seems idempotent and safe to call if the deps are started elsewhere.