board: add reel_board and reel_board_v2 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeros
reviewed
Dec 19, 2020
boards/reel_board.json
Outdated
| @@ -0,0 +1,44 @@ | |||
| { | |||
| "build": { | |||
| "core": "nRF5", | |||
There was a problem hiding this comment.
This field is mostly used with Arduino framework. nRF5 core doesn't support this board, so it seems redundant to me.
valeros
reviewed
Dec 19, 2020
boards/reel_board.json
Outdated
| "core": "nRF5", | ||
| "cpu": "cortex-m4", | ||
| "f_cpu": "64000000L", | ||
| "mcu": "nrf52832", |
There was a problem hiding this comment.
Looks like you forget to change the MCU name
valeros
reviewed
Dec 19, 2020
boards/reel_board.json
Outdated
Comment on lines
8
to
11
| [ | ||
| "0x0D28", | ||
| "0x0204" | ||
| ] |
valeros
reviewed
Dec 19, 2020
boards/reel_board.json
Outdated
| "0x0204" | ||
| ] | ||
| ], | ||
| "variant": "reel_board" |
There was a problem hiding this comment.
Please move the variant field to the zephyr section as it done in this manifest.
|
Hi @jremmert-phytec-iot ! Thanks for the PR. Please see my comments above, they apply to both boards. |
reel_board and reel_board_v2 differ in the passive display being used.
Thanks for review @valeros! I addressed all your comments and did a force push. |
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reel_board and reel_board_v2. The main platform for the reel_board is Zephyr. More information can be found in the documentation page of the reel board within the Zephyr project.
I tested the boards here locally and building, debugging and serial monitor works for me. Is there a way to make a baudrate of 115200 the default for this board? Zephyr uses 115200 for most of the examples.
reel_board and reel_board_v2 differ in the passive display being used. I created two different boards. Not sure if there is a more elegant way to go?