Fix nrfutil upload for Zephyr OS

[danielstuart14]

This commit fixes nrfutil upload on Zephyr OS and non-adafruit devices.

Prior to this, an error was being raised as the .zip package wasn't
being generated.

[FlomoN]

Using this fork currently is the only option for me to program my Adafruit Feather nrf52840 express because otherwise I will get:

Verbose mode can be enabled via `-v, --verbose` option
CONFIGURATION: https://docs.platformio.org/page/boards/nordicnrf52/adafruit_feather_nrf52840.html
PLATFORM: Nordic nRF52 (9.0.0) > Adafruit Feather nRF52840 Express
HARDWARE: NRF52840 64MHz, 243KB RAM, 796KB Flash
DEBUG: Current (blackmagic) External (blackmagic, cmsis-dap, jlink, stlink)
PACKAGES: 
 - framework-cmsis 2.50700.210515 (5.7.0)
 - framework-zephyr 2.20700.211026 (2.7.0)
 - tool-adafruit-nrfutil 1.503.0 (5.3)
 - tool-bossac-nordicnrf52 1.10901.201022 (1.9.1)
 - tool-cmake 3.21.3
 - tool-dtc 1.4.7
 - tool-ninja 1.9.0
 - tool-openocd 2.1100.211028 (11.0)
 - tool-sreccat 1.164.0 (1.64)
 - toolchain-gccarmnoneeabi 1.80201.190214 (8.2.1)
LDF: Library Dependency Finder -> https://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 0 compatible libraries
Scanning dependencies...
No dependencies
Building in release mode
Checking size .pio\build\default\firmware.elf
Advanced Memory Usage is available via "PlatformIO Home > Project Inspect"
RAM:   [          ]   1.6% (used 4071 bytes from 248832 bytes)
Flash: [          ]   1.5% (used 12240 bytes from 815104 bytes)
Configuring upload protocol...
AVAILABLE: blackmagic, cmsis-dap, jlink, nrfjprog, nrfutil, stlink
CURRENT: upload_protocol = nrfutil
Looking for upload port...
Auto-detected: COM8
Forcing reset using 1200bps open/close on port COM8
Waiting for the new upload port...
Uploading .pio\build\default\firmware.hex
Traceback (most recent call last):
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\adafruit-nrfutil.py", line 12, in <module>
    cli()
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\click\core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\click\core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\click\core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\click\core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\click\core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\click\core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\nordicsemi\__main__.py", line 290, in serial
    dfu = Dfu(package, dfu_transport=serial_backend)
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\nordicsemi\dfu\dfu.py", line 66, in __init__
    self.manifest = Package.unpack_package(self.zip_file_path, self.unpacked_zip_path)
  File "C:\Users\flogi\.platformio\packages\tool-adafruit-nrfutil\site-packages\nordicsemi\dfu\package.py", line 361, in unpack_package
    with ZipFile(package_path, 'r') as pkg:
  File "C:\Python38\lib\zipfile.py", line 1269, in __init__
    self._RealGetContents()
  File "C:\Python38\lib\zipfile.py", line 1336, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file
*** [upload] Error 1

Would like to see this merged.

[danielstuart14]

Any possibility of this getting merged?

[valeros]

Many thanks for the PR, merged!