Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adafruit QT PY S3 with 4MB flash 2 MB PSRAM #1181

Closed
wants to merge 2 commits into from

Conversation

R41K
Copy link

@R41K R41K commented Sep 3, 2023

Please add support for this board: https://www.adafruit.com/product/5700 .
The _nopsram variant does not work because it requires 8MB flash_size but this board has only 4mb flash + 2mb psram.
I tested it with a blink sketch.

R41K added 2 commits September 2, 2023 05:44
Add Adafruit QT PY S3 with 4MB flash 2 MB PSRAM
@awwaiid
Copy link

awwaiid commented Dec 16, 2023

I'm using the slightly different variant at https://community.platformio.org/t/adafruit-qt-py-s3-with-2mb-psram/37256/2 and it works great.

@R41K
Copy link
Author

R41K commented Jan 1, 2024

Hi @valeros, I am not much of a developer and not so deep in PIO but I gave it a shot and created this PR. Apparently it was kind of ignored/unprocessed for three months without any obvious reason. So may I ask if anything was wrong with this PR? It makes me wonder a bit why #1257 got such a fast response and got pulled almost immediately. Even though there was no support of TinyUF2 and some other small things, I would have expected that these topics come up when there is a Review from your side, which did not happen. I've spent some time and effort on this and want to avoid other experiences like this in the future. Would be nice to get some insights why it was unprocessed for so long and how to get requests processed faster in the future. Thanks, R41K

@valeros
Copy link
Member

valeros commented Jan 9, 2024

Hi @R41K, I'm sorry that your PR didn't get much attention, please be sure I'm not prejudiced against anyone. Usually, I review PRs with new board manifests when I'm updating the Arduino core to the latest version. This last update of the Arduino core with support for the Adafruit QT PY S3 board was significantly delayed (as you mentioned for several months), so that when the moment to update came, there was that new PR with a bit better implementation.

All contributions are welcome, if the new PR with support for TUF2 hadn't been added, of course I would've reviewed yours. It was just a unfortunate coincidence that your PR has gone unnoticed.

jonathandreyer pushed a commit to jonathandreyer/platform-espressif32 that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants