-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to loadAppsInChat to exclude apps without a bot #73
Conversation
@@ -135,6 +135,7 @@ export const loadMoreChatMessages = async (graph: IGraph, nextLink: string): Pro | |||
export const loadAppsInChat = async (graph: IGraph, chatId: string): Promise<AppCollection> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be called loadBotsInChat now since it doesn't include apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to change name. Maybe there is even an opportunity to reduce filtering code where this is used.
There are quite a few places that refer to this as "apps" whereas it is now "bots". |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And now all this might change with Gavin's PR on bots: microsoftgraph#3071
Task 493
Tested in ChatList that loading a Bot chat calls the API with a filter now
PR Type
Description of the changes
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information