Fix spinners harder #714
Merged
Fix spinners harder #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 I don't recall merging this. I think because it was targeting beta the PR got auto-closed when I merged it to deploy there. Oops, I will reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another fix for notes failing to load and showing infinite spinners. I started by writing a good test to exhibit the issue, which required me to pull in the ViewObservation swift package. Then I started playing with the contexts and found that changing the
parseContext.parenttoviewContextinstead of nil fixed the issue where theNSManagedObjectIDbeing held by the view would change on disk and the view would never be notified of changes to the object.I did some testing to see if this had any negative side effects (like my last attempt did, #632) and I haven't seen any yet. But let's keep an eye out. This should close #697 and #703.