Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu to stories avatars #664

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add context menu to stories avatars #664

merged 3 commits into from
Dec 12, 2023

Conversation

martindsq
Copy link
Member

This is my first attempt to add context menus to nos. It just adds the ability to open the profile by long pressing on an avatar in the row of stories at the top of the home feed, we can add followinf or other actions there, but this is just a single iteration to see what others think about this.

PS: I could add a context menu to all note buttons to maybe add liking notes, replying, etc, but it seemed a bit to drastic to add it without design feedback.

@martindsq martindsq requested a review from mplorentz November 20, 2023 16:10
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I wish the sides of the border weren't cut off, not sure what can be done about that.
IMG_6962F34BC9F4-1

@martindsq
Copy link
Member Author

Let's wait until demo day to see if we can merge this

@martindsq
Copy link
Member Author

Fixed that, I think it is ready to be merged now

simulator_screenshot_1498C174-DFE0-4433-AAA3-4A9BAFC3DCA6

@martindsq martindsq merged commit 05f76ad into main Dec 12, 2023
3 checks passed
@martindsq martindsq deleted the itches/context_menu branch December 12, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants