Skip to content

Commit

Permalink
Merge pull request #662 from planetary-social/fix-follower-count
Browse files Browse the repository at this point in the history
Change followers to followers you know and fix bug in follow count
  • Loading branch information
mplorentz authored Nov 21, 2023
2 parents 5768ea9 + 2a1643d commit bd03cd0
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Change the "Followed by" label on the profile screen to "Followers you know"
- Fixed an issue where the Profile view would always show "Following 0" for people you didn't follow.
- Fixed the 3d card effect on the Notifications tab.

## [0.1 (93)] - 2023-11-10Z
Expand Down
3 changes: 2 additions & 1 deletion Nos/Assets/Localization/Localized.swift
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,10 @@ enum Localized: String, Localizable, CaseIterable {
case profileTitle = "Profile"
case profile = "profile"
case follow = "Follow"
case followers = "Followers"
case follows = "Follows"
case following = "Following"
case followedBy = "Followed by"
case followersYouKnow = "Followers you know"
case followedByOne = "Followed by **{{ one }}**"
case followedByOneAndMore = "Followed by **{{ one }}** and **{{ count }} others**"
case followedByTwo = "Followed by **{{ one }}** and **{{ two }}**"
Expand Down
3 changes: 2 additions & 1 deletion Nos/Assets/Localization/en.lproj/Generated.strings
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,10 @@
"Localized.profileTitle" = "Profile";
"Localized.profile" = "profile";
"Localized.follow" = "Follow";
"Localized.followers" = "Followers";
"Localized.follows" = "Follows";
"Localized.following" = "Following";
"Localized.followedBy" = "Followed by";
"Localized.followersYouKnow" = "Followers you know";
"Localized.followedByOne" = "Followed by **{{ one }}**";
"Localized.followedByOneAndMore" = "Followed by **{{ one }}** and **{{ count }} others**";
"Localized.followedByTwo" = "Followed by **{{ one }}** and **{{ two }}**";
Expand Down
2 changes: 1 addition & 1 deletion Nos/Views/ProfileSocialStatsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct ProfileSocialStatsView: View {
)
)
} label: {
tab(label: .followedBy, value: author.followers.count)
tab(label: .followersYouKnow, value: author.followers.count)
}
Spacer(minLength: 0)
}
Expand Down
4 changes: 2 additions & 2 deletions Nos/Views/ProfileView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ struct ProfileView: View {
contentsOf: await relayService.requestProfileData(
for: authorKey,
lastUpdateMetadata: author.lastUpdatedMetadata,
lastUpdatedContactList: author.lastUpdatedContactList
lastUpdatedContactList: nil // always grab contact list because we purge follows aggressively
)
)

Expand Down Expand Up @@ -147,7 +147,7 @@ struct ProfileView: View {
FollowsView(title: Localized.follows, authors: destination.follows)
}
.navigationDestination(for: FollowersDestination.self) { destination in
FollowsView(title: Localized.followedBy, authors: destination.followers)
FollowsView(title: Localized.followers, authors: destination.followers)
}
.navigationDestination(for: RelaysDestination.self) { destination in
RelayView(author: destination.author, editable: false)
Expand Down

0 comments on commit bd03cd0

Please sign in to comment.