pkp/pkp-lib#10820 Display error summary at the top of the page with multiple forms #494
+106
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jardakotesovec
requested changes
Jan 26, 2025
There was a problem hiding this comment.
Looking good.
Maybe check the messaging with Devika, as the wording 3 errors detected! Please correct the following errors before proceeding. works well if the errors would be listed. But since we don't listen to them.. maybe something like correct errors below before proceeding would be better fit?
Once thats settled you can add translation to the common.po
blesildaramirez
force-pushed
the
i10820
branch
from
3708dd5 to
09e4ca3
Compare
jardakotesovec
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.