Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to fix GitHub build action #955

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

NateWr
Copy link
Contributor

@NateWr NateWr commented Apr 13, 2022

No description provided.

@NateWr NateWr requested a review from AhemNason April 13, 2022 08:41
@NateWr
Copy link
Contributor Author

NateWr commented Apr 13, 2022

@AhemNason we had a problem with some of our dependencies and it broke the GitHub action that tests the build. In this PR, I've updated the dependencies. But I want to make sure that you can still build the docs hub, so that we don't accidentally get you into a tricky position.

To test this out properly, can you:

  1. Clone my repository from scratch. (To make sure the dependency packages are fresh.)
  2. Check out my branch (git checkout dependencies).
  3. Run bundle install to install the dependencies.
  4. Run bundle exec jekyll build to build the site.

Let me know if that all goes smoothly for you. If not, we'll hold off on these changes until we have time to work through the issues together.

@AhemNason
Copy link
Collaborator

Went smoothly, with no issues!

@NateWr NateWr merged commit 1f028a6 into pkp:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants