Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROR Id support for default template #2912

Merged
merged 2 commits into from
Nov 26, 2020
Merged

ROR Id support for default template #2912

merged 2 commits into from
Nov 26, 2020

Conversation

withanage
Copy link
Member

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2020

CLA assistant check
All committers have signed the CLA.

@withanage withanage requested review from NateWr and removed request for NateWr November 23, 2020 13:39
@NateWr
Copy link
Contributor

NateWr commented Nov 24, 2020

Let's only link the icon, not the full name of the institution, to the rorId. Once that's changed, I'm happy to merge this but I would prefer to merge this only when the plugin is available in the galley. Are you close to a release?

@withanage
Copy link
Member Author

@NateWr

Thanks! Have changed it.

I have finished the plugin already for the first release and asked some people to test. Have to write the README. This Thursday, I will finish that and will create a plugin-gallery PR.

@NateWr
Copy link
Contributor

NateWr commented Nov 25, 2020

Ok let me know on Thursday. I'd like to get it into the 3.3 RC if we can.

@NateWr NateWr merged commit 3ffe302 into pkp:stable-3_2_1 Nov 26, 2020
NateWr added a commit that referenced this pull request Nov 26, 2020
ROR Id support for default template
@NateWr
Copy link
Contributor

NateWr commented Nov 26, 2020

Ok, i've merged this to stable-3_2_1 and forward-ported it to the master branch for 3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants